[master] Update dependencies from dotnet/arcade #277
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![dotnet-maestro[bot]](https://avatars.githubusercontent.com/in/16706?s=60&v=4){kind=small}
…317.10 This change updates the following dependencies - Microsoft.DotNet.Arcade.Sdk - 1.0.0-beta.19167.10
Auto-Merge StatusThis pull request has not been merged because Maestro++ is waiting on the following merge policies.
|
…320.2 - Microsoft.DotNet.Arcade.Sdk - 1.0.0-beta.19170.2
|
@tmat what is the correct way to fix this nuget licensing issue? |
Auto-Merge StatusThis pull request has been merged because the following merge policies have succeeded.
|
tmat
reviewed
Mar 22, 2019
| @@ -8,7 +8,12 @@ | |||
| </PropertyGroup> | |||
|
|
|||
| <Import Project="Sdk.props" Sdk="Microsoft.DotNet.Arcade.Sdk" /> | |||
|
|
|||
|
|
|||
| <PropertyGroup Condition="'$(CopyrightMicrosoft)' != ''"> | |||
There was a problem hiding this comment.
Condition="'$(CopyrightMicrosoft)' != ''" shouldn't be necessary anymore. Arcade now defines the property globally.
There was a problem hiding this comment.
so just this?
<PropertyGroup>
<PackageLicenseExpression>Apache-2.0</PackageLicenseExpression>
</PropertyGroup>There was a problem hiding this comment.
No, include the Copyright, just not the condition.
dotnet-maestro
bot
deleted the
darc-master-36a646e2-1925-4a5c-9726-c2fd3a992d89
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request updates the following dependencies
Updates from https://github.com/dotnet/arcade
From https://github.com/dotnet/arcade
From https://github.com/dotnet/arcade